Skip to content

CID-1508974 #10397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryancall merged 2 commits into from
Sep 11, 2023
Merged

CID-1508974 #10397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5c71a0
check try lock return value
Sep 11, 2023
24c247b
add break statement to prevent fallthrough
Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion example/plugins/c-api/protocol/Protocol.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
#include "tscore/ink_defs.h"
#include <math.h>

#define RETRY_TIME 10

/* global variable */
TSTextLogObject protocol_plugin_log;

Expand Down Expand Up @@ -54,7 +56,13 @@ accept_handler(TSCont contp, TSEvent event, void *edata)

/* This is no reason for not grabbing the lock.
So skip the routine which handle LockTry failure case. */
TSMutexLockTry(pmutex); // TODO: why should it not check if we got the lock??

// check if grabbing the lock is successful
if (TSMutexLockTry(pmutex) != TS_SUCCESS) {
TSDebug(PLUGIN_NAME, "Unable to get lock. Will retry after some time");
TSContScheduleOnPool(contp, RETRY_TIME, TS_THREAD_POOL_NET);
break;
}
TSContCall(txn_sm, TS_EVENT_NONE, nullptr);
TSMutexUnlock(pmutex);
break;
Expand Down