Skip to content

Conversation

@zwoop
Copy link
Contributor

@zwoop zwoop commented Sep 15, 2023

No description provided.

@zwoop zwoop added this to the 10.0.0 milestone Sep 15, 2023
@zwoop zwoop requested a review from ezelkow1 September 15, 2023 16:22
@zwoop zwoop self-assigned this Sep 15, 2023
@ezelkow1 ezelkow1 requested a review from traeak September 15, 2023 16:32
traeak
traeak previously approved these changes Sep 15, 2023
Copy link
Contributor

@traeak traeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are fine except that cmake is now broken.

@zwoop
Copy link
Contributor Author

zwoop commented Sep 17, 2023

Fixed cmake, please review again

Copy link
Contributor

@traeak traeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@zwoop zwoop merged commit d4a8f2f into apache:master Sep 18, 2023
@zwoop zwoop deleted the PromoteSlice branch September 18, 2023 22:11
@maskit maskit mentioned this pull request Aug 16, 2024
91 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants