Update to libswoc 1.5.9 #10944
Update to libswoc 1.5.9 #10944
Conversation
SolidWallOfCode
force-pushed
the
libswoc-1-5-9
branch
from
465b744 to
ce3831a
Compare
| */ | ||
| self_type ¬e(Severity severity, std::string_view text); | ||
|
|
||
| /** Add an @c Annotation to the top with @a text and local @a severity. |
| } | ||
|
|
||
| inline bool | ||
| IPAddr::operator==(self_type const &that) const { |
There was a problem hiding this comment.
self_type has more characters than IPAddr. Are you having a hard time staying busy in retirement?
| protected: | ||
| IP4Addr _addr; ///< Address. | ||
| in_port_t _port = 0; ///< Port. | ||
| in_port_t _port = 0; ///< Port [host order]. |
There was a problem hiding this comment.
why [ host order] not (host order)?
| self_type &assign(IP6Addr const &addr, in_port_t port); | ||
|
|
||
| /** Change the address and port. | ||
| /** Assogm address amd [prt/ |
|
|
||
| size_t _active_allocated = 0; ///< Total allocations in the active generation. | ||
| size_t _active_reserved = 0; ///< Total current reserved memory. | ||
| size_t _active_reserved = 0; ///< Total reserved memory (allocated from OS). |
There was a problem hiding this comment.
I think you mean "allocated from the compiler runtime library allocator"?
| uintmax_t | ||
| svto_radix(TextView &src) { | ||
| static_assert(0 < RADIX && RADIX <= 36, "Radix must be in the range 1..36"); | ||
| static_assert(1 <= RADIX && RADIX <= 36, "Radix must be in the range 2..36"); |
| } | ||
|
|
||
| inline bool is_link_local_host_order(in_addr_t addr) { | ||
| return (addr & 0xFFFF0000) == 0xA9FE0000; // 169.254.0.0/16 |
There was a problem hiding this comment.
((169 << 24)|(254 << 16)) is less error-prone.
| return (addr.s6_addr[0] & 0xFE) == 0xFC; // fc00::/7 | ||
| } | ||
|
|
||
| #if BYTE_ORDER == LITTLE_ENDIAN |
There was a problem hiding this comment.
I think it would be more robust to use:
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html
| } | ||
| } | ||
| } | ||
| if (!(1 <= base && base <= 36)) { |
There was a problem hiding this comment.
How can you have a base 1 number representation?
|
We don't make local changes for libswoc on ATS repo, right? If 1.5.9 has issues we simply don't use the version, and hope a new version doesn't have issues. Also, code change for libsowc should be reviewed on its repo but not here. |
Correct. I'm going to go ahead and merge this in before things conflict with it. |
This is in preparation for some significant ATS updates, including * Avoiding ats_ip_copy * Final removal of the old Errata * Replacement of Arena by MemArena.
4 participants
This is in preparation for some significant ATS updates, including
ats_ip_copyErrataArenabyMemArena.Release notes:
Just in time for the holidays, a new release of libSWOC! This is a bit bigger than other recent point releases due to increased integration in ATS.
svtoi.notemethod.discardallocated spans.Fixes #10934