Restore IntrusiveHashMap insert code from tscore (ats92) #10992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywkaras
previously requested changes
Jan 18, 2024
Contributor
ywkaras
left a comment
ywkaras
left a comment
There was a problem hiding this comment.
Before Alan's passing, the code in the lib/swoc tree was copied from labeled version in https://github.com/SolidWallOfCode/libswoc . We have to decide where the maintained source is going to be, to make PRs against it.
bneradt
approved these changes
Jan 22, 2024
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
I verified that this block was added in libswoc and wasn't in tscore. I'm sure this was added for a reason, but it since it introduces serious origin side connection problems, I'm OK with backing it out at least for now.
bryancall
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an extra snippet of code added with the libswoc implementation of IntrusiveHashMap which causes a noticeable performance hit (expansion of the critical section) when inserting items into the session pool. Specific test case used saw on average an increase of about 6x in the HttpSessionManager critical sections.
The change introduced with libswoc (not documented in any checkin) appends the new item to the bucket list, which was not done with the tscore (ats92) version.