TS-4959: Remove remnants of old UA configurations and handling #1101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 - Looks good |
jpeach
approved these changes
Oct 12, 2016
Contributor
jpeach
left a comment
jpeach
left a comment
There was a problem hiding this comment.
Looks good, but consider not removing the enums, since that breaks the ABI.
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/985/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/877/ for details. |
Contributor
Author
|
Rebuilding again, because I think the trees on the buildbots was busted [approve ci]. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/988/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/880/ for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this as two commits:
Remove some definitely strange code around MSIE.
Remove all the code around the accept_encoding_filter_enabled.
For #2, this configuration doesn't actually exist in RecordsConfig.cc, and it's also missing all possible ways of configuring the regular expressions that it needs. So I figured, we can just nuke it :).