Ensure connection retry attempts can reach the config specified value #11021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is a 9.2.x specific issue and the master doesn't have it because of some refactoring, right? |
Contributor
|
This is related to #9620 that landed on master. |
ywkaras
reviewed
Jan 30, 2024
|
|
||
| // Are we done with this particular parent? | ||
| if ((s->current.attempts - 1) % s->txn_conf->per_parent_connect_attempts != 0) { | ||
| if (s->current.attempts % s->txn_conf->per_parent_connect_attempts != 0) { |
Contributor
There was a problem hiding this comment.
Seems to match ATS 10:
trafficserver/src/proxy/http/HttpTransact.cc
Line 3617 in f180ea2
ywkaras
approved these changes
Jan 30, 2024
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Dec 10, 2024
…apache#11021) (cherry picked from commit 1859692)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current logic, when
s->current.attempts = 1, the if statement on line 3695 will always be false because 0 % anything is 0.Removing the -1 so the if statement will only be false when the retry attempts number is reached.
Should close #11006