Restore alignment for structs stored in cache #11167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
approved these changes
Mar 18, 2024
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good.
Out of curiosity, were there warnings or the like due to the misalignment?
Contributor
Author
Release assertions running 10.0.0 with caches created with 9.2 |
Contributor
Author
|
I've tested this PR in production and it no longer hits the asserts. |
Contributor
Author
|
Cherry-picked to v10.0.x |
cmcfarlen
added a commit
that referenced
this pull request
Mar 19, 2024
(cherry picked from commit b4f1fca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9481 changed the alignment on structs that are stored in cache. This breaks the cache.