Skip to content

Remove noisy retransmit Note messages #11225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bneradt merged 1 commit into from
Apr 8, 2024
Merged

Remove noisy retransmit Note messages #11225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/proxy/http2/Http2CommonSession.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ Http2CommonSession::xmit(const Http2TxFrame &frame, bool flush)
if (this->_pending_sending_data_size >= this->_write_size_threshold) {
flush = true;
} else {
Note("Calling schedule_transmit because write threshold is not exceeded.");
// Observe that schedule_transmit will only schedule the first time we
// don't flush because the threshold is not met.
this->connection_state.schedule_retransmit(HRTIME_MSECONDS(Http2::write_time_threshold));
Expand Down
3 changes: 0 additions & 3 deletions src/proxy/http2/Http2ConnectionState.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1489,7 +1489,6 @@ Http2ConnectionState::main_event_handler(int event, void *edata)
case HTTP2_SESSION_EVENT_XMIT: {
REMEMBER(event, this->recursion);
SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
Note("Flushing due to XMIT event");
this->session->flush();
} break;

Expand Down Expand Up @@ -2100,8 +2099,6 @@ Http2ConnectionState::schedule_retransmit(ink_hrtime t)
SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());

if (retransmit_event == nullptr) {
Note("Scheduling retransmit in %" PRId64 "ms", t / HRTIME_MSECOND);

SET_HANDLER(&Http2ConnectionState::main_event_handler);
retransmit_event = this_ethread()->schedule_in((Continuation *)this, t, HTTP2_SESSION_EVENT_XMIT);
}
Expand Down