Enable ASan on CI Rocky preset #11332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
[approve ci] |
Contributor
Author
|
Following @bneradt's advice, enabling ASan on rocky instead of adding another preset. |
Contributor
Author
|
gcc-toolset-11 doesn't like UBSan :( |
bneradt
requested changes
May 10, 2024
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Thanks for setting on ci-rocky. It will be good to get this coverage in PR CI.
CMakePresets.json
Outdated
Comment on lines
155
to
156
| "CMAKE_CXX_FLAGS_DEBUG": "-g -fsanitize=address", | ||
| "CMAKE_C_FLAGS_DEBUG": "-g -fsanitize=address" |
Contributor
There was a problem hiding this comment.
We should be able to use "ENABLE_ASAN": "ON", instead of setting the flags. That would be preferable. Can you also use ENABLE_ASAN for the other places in here that set those -fsanitize=address flags?
Contributor
Author
There was a problem hiding this comment.
Sure. For the other places, I'll open another PR.
Contributor
Author
|
[approve ci rocky] |
bneradt
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.