Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/iocore/cache/CacheWrite.cc
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ CacheVC::updateVector(int /* event ATS_UNUSED */, Event * /* e ATS_UNUSED */)
agg queue. And if !f.evac_vector && !f.update the alternate->object_size
is set to vc->total_len
- f.readers. If set, assumes that this is an evacuation, so the write
is not aborted even if vol->get_agg_todo_size() > agg_write_backlog
is not aborted even if
stripe->_write_buffer.get_bytes_pending_aggregation() > agg_write_backlog
- f.evacuator. If this is an evacuation.
- f.rewrite_resident_alt. The resident alternate is rewritten.
- f.update. Used only if the write_vector needs to be written to disk.
Expand Down
2 changes: 1 addition & 1 deletion src/iocore/cache/P_CacheInternal.h
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ Stripe::open_write(CacheVC *cont, int allow_if_writers, int max_writers)
Stripe *stripe = this;
bool agg_error = false;
if (!cont->f.remove) {
agg_error = (!cont->f.update && this->get_agg_todo_size() > cache_config_agg_write_backlog);
agg_error = (!cont->f.update && this->_write_buffer.get_bytes_pending_aggregation() > cache_config_agg_write_backlog);
#ifdef CACHE_AGG_FAIL_RATE
agg_error = agg_error || ((uint32_t)mutex->thread_holding->generator.random() < (uint32_t)(UINT_MAX * CACHE_AGG_FAIL_RATE));
#endif
Expand Down
7 changes: 0 additions & 7 deletions src/iocore/cache/P_CacheVol.h
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,6 @@ class Stripe : public Continuation

Queue<CacheVC, Continuation::Link_link> &get_pending_writers();
int get_agg_buf_pos() const;
int get_agg_todo_size() const;

/**
* Add a virtual connection waiting to write to this stripe.
Expand Down Expand Up @@ -550,9 +549,3 @@ Stripe::get_agg_buf_pos() const
{
return this->_write_buffer.get_buffer_pos();
}

inline int
Stripe::get_agg_todo_size() const
{
return this->_write_buffer.get_bytes_pending_aggregation();
}