Skip to content

txn_box: Address use after free in Do_upstream_rsp_body #11428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bneradt merged 1 commit into from
Jun 11, 2024
Merged

txn_box: Address use after free in Do_upstream_rsp_body #11428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions plugins/experimental/txn_box/plugin/src/Machinery.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2538,9 +2538,13 @@ Do_upstream_rsp_body::invoke(Context &ctx)
struct State {
TextView _view; ///< Source view for body.
TSIOBuffer _tsio_buff = nullptr; ///< Buffer used to write body.
TSCont _cont = nullptr; ///< Transform continuation with which State is associated.
/// Clean up the @c IOBuffer.
~State()
{
if (_cont != nullptr) {
TSContDataSet(_cont, nullptr);
}
if (_tsio_buff) {
TSIOBufferDestroy(_tsio_buff);
}
Expand All @@ -2550,6 +2554,10 @@ Do_upstream_rsp_body::invoke(Context &ctx)
auto static transform = [](TSCont contp, TSEvent ev_code, void *) -> int {
if (TSVConnClosedGet(contp)) {
// IOBuffer is cleaned up at transaction close, not here.
if (auto state = static_cast<State *>(TSContDataGet(contp)); state) {
state->_cont = nullptr;
TSContDataSet(contp, nullptr);
}
TSContDestroy(contp);
return 0;
}
Expand Down Expand Up @@ -2614,6 +2622,7 @@ Do_upstream_rsp_body::invoke(Context &ctx)
auto state = ctx.make<State>();
ctx.mark_for_cleanup(state);
auto cont = TSTransformCreate(transform, ctx._txn);
state->_cont = cont;
state->_view = *content;
TSContDataSet(cont, state);
TSHttpTxnHookAdd(ctx._txn, TS_HTTP_RESPONSE_TRANSFORM_HOOK, cont);
Expand Down