Clean up agg_copy #11456
Merged
Clean up agg_copy #11456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosiahWI
force-pushed
the
refactor/agg-copy
branch
2 times, most recently
from
694a78c to
d954467
Compare
Contributor
Author
JosiahWI
force-pushed
the
refactor/agg-copy
branch
from
d954467 to
ebaf3c0
Compare
Contributor
Author
|
I made a rebase mistake; one of the metrics isn’t initialized. The error message for this could be improved. |
JosiahWI
force-pushed
the
refactor/agg-copy
branch
from
931f45c to
9268e80
Compare
Contributor
Author
|
I have finished rebasing. |
masaori335
reviewed
Jul 11, 2024
masaori335
previously approved these changes
Jul 11, 2024
Contributor
masaori335
left a comment
masaori335
left a comment
There was a problem hiding this comment.
It looks like this is just moving code and no behavior changes.
masaori335
reviewed
Jul 11, 2024
* Elide temporary mutex variable for `ink_assert` It's obvious from the context of the method calls that the variable holds the raw stripe mutex. The temporary variable clarifies nothing. * Move the new `Doc` methods to a source file This adds the CacheDoc.cc file. If some of the methods such as `pin` and `unpin` cause a performance problem by not being inlined, we can easily move them back to the header. For now, keeping the implementation in a source file helps speed up compile times and limits dependency scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
Stripe::agg_copywith the goal of making it a bit more understandable. I've tried to improve some variable names and extract a few functions where it makes sense. There should be no behavioral change and the specific changes made should be covered pretty well by the existing unit tests. I think the only logic changes are in 4f133d9, 50c1393 (the order of two assignments was swapped), and d954467.