Fix unused function parameters in the plugins functionality #11466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosiahWI
requested changes
Jun 21, 2024
Contributor
JosiahWI
left a comment
JosiahWI
left a comment
There was a problem hiding this comment.
Looks good. It'd be great if we could remove a few of these unused parameters as well.
This was suggested during a review of the pull request
Contributor
Author
|
@JosiahWI |
JosiahWI
approved these changes
Jun 21, 2024
Contributor
JosiahWI
left a comment
JosiahWI
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
cmcfarlen
approved these changes
Jun 21, 2024
Contributor
|
Cherry-picked to v10.0.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Jun 21, 2024
* Fix unused function parameters in the plugins functionality * Completely remove some unused parameters in the plugins functionality This was suggested during a review of the pull request (cherry picked from commit 29fa13a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
/* name ATS_UNUSED */for fully unused parameters.Use
[[maybe_unused]]attribute for conditionally unused parameters used in asserts.This pull request is part of the effort for removing the
-Wno-unused-parameterwarning suppression.