Remove pathset for urlsig #11599
Merged
Remove pathset for urlsig #11599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 2 tests, one with a bad path param and one with a properly encoded path param. ATS returns 403 and 200 properly but cannot get autest to register these outputs yet Added path param checks for success and failure, shuffled tests for correct logging output
maskit
approved these changes
Jul 24, 2024
12 tasks
Contributor
|
Cherry-picked to v10.0.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Jul 26, 2024
Added 2 tests, one with a bad path param and one with a properly encoded path param. ATS returns 403 and 200 properly but cannot get autest to register these outputs yet Added path param checks for success and failure, shuffled tests for correct logging output (cherry picked from commit 9d6c2b2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 tests, one with a bad path param and one with a properly encoded path param. ATS returns 403 and 200 properly
Added path param checks for success and failure, shuffled tests for correct logging output
If there is a spurious path param in a request to urlsig it's going to 403 because it will not match the signature provided. So that should be why it is ok to remove the ParamsSet here since if there are no path params then the new path does not need to be set and params dont need to be updated. If there are path params, and they are good, then the new path will be set which includes the params. If there are path params but they are bad then it is going to 403 anyway