Skip to content

Conversation

@maskit
Copy link
Member

@maskit maskit commented Jul 23, 2024

Apparently we lost --disable-tests build option when we switched to cmake. And because of that, regression tests for InkAPI are not run since the switch.

We may want to add back the build option, but this PR just include the tests for now.

@maskit maskit added Build work related to build configuration or environment Tests labels Jul 23, 2024
@maskit maskit added this to the 10.1.0 milestone Jul 23, 2024
@maskit maskit self-assigned this Jul 23, 2024
Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix the building of InkAPIInternal.cc:

maskit#3

@maskit maskit marked this pull request as draft July 23, 2024 22:08
@maskit
Copy link
Member Author

maskit commented Jul 23, 2024

Regression tests for TSUrlHttpParamsSet&Get failed. We need to finish #11566 first.

@maskit maskit force-pushed the inc_inkapi_regression_test branch from c036d14 to c8cd4f4 Compare August 5, 2024 21:49
@maskit maskit force-pushed the inc_inkapi_regression_test branch from 333b82c to 4a5915e Compare August 5, 2024 22:36
@maskit maskit marked this pull request as ready for review August 5, 2024 23:01
@maskit maskit requested a review from bneradt August 5, 2024 23:01
@maskit maskit merged commit 0c779e2 into apache:master Aug 6, 2024
@cmcfarlen cmcfarlen modified the milestones: 10.1.0, 10.0.0 Aug 7, 2024
@cmcfarlen
Copy link
Contributor

Cherry-picked to v10.0.x

cmcfarlen pushed a commit that referenced this pull request Aug 7, 2024
* Run regression tests for InkAPI

* Fix building of InkAPITest.cc

* Include InkAPITest.cc only if BUILD_REGRESSION_TESTING is on

* Remove tests for TSUrlHttpParamsSet

* Fix a test for TSUrlStringGet

---------

Co-authored-by: Brian Neradt <brian.neradt@gmail.com>
(cherry picked from commit 0c779e2)
@maskit maskit deleted the inc_inkapi_regression_test branch September 18, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build work related to build configuration or environment Tests

Projects

Status: picked-10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants