Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting TLS groups with BoringSSL #11840

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

masaori335
Copy link
Contributor

I found that SSLMultiCertConfigLoader::_set_curves function is not working as expected with BoringSSL. Because this check doesn't work with BoringSSL, because it's defined as a function instead of macro.

#if defined(SSL_CTX_set1_groups_list) || defined(SSL_CTX_set1_curves_list)

@masaori335 masaori335 added the TLS label Nov 1, 2024
@masaori335 masaori335 added this to the 10.1.0 milestone Nov 1, 2024
@masaori335 masaori335 self-assigned this Nov 1, 2024
maskit
maskit previously requested changes Nov 1, 2024
Copy link
Member

@maskit maskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No duplicate code please.

@masaori335
Copy link
Contributor Author

The SSL_CTX_set1_groups_list function is introduced by OpenSSL 1.1.1, and that is ATS 10's minimum supported version.
Thus, we just don't need these ifdefs, I think.

For 9.2.x branch, I'll open another PR.

@masaori335 masaori335 merged commit a860656 into apache:master Nov 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: For v10.0.2
Development

Successfully merging this pull request may close these issues.

3 participants