Add TSVConnPPInfoGet #12032
Merged
Add TSVConnPPInfoGet #12032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[approve ci autest 2] |
bneradt
requested changes
Mar 31, 2025
| Return the particular PROXY protocol info requested. | ||
| @param vconn the vconection pointer | ||
| @param key the requested PROXY protocol info. One of TSVConnPPInfoKey or TLV type ID |
Contributor
There was a problem hiding this comment.
This one has to be a TSVConnPPInfoKey value, right? Should it take a TSVConnPPInfoKey type rather than a uint16_t?
Member
Author
There was a problem hiding this comment.
No, because it can be a non-standard value.
https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt
The following range of 16 type values is reserved for application-specific
data and will be never used by the PROXY Protocol. If you need more values
consider extending the range with a type field in your TLVs.
#define PP2_TYPE_MIN_CUSTOM 0xE0
#define PP2_TYPE_MAX_CUSTOM 0xEF
This range of 8 values is reserved for temporary experimental use by
application developers and protocol designers. The values from the range will
never be used by the PROXY protocol and should not be used by production
functionality.
#define PP2_TYPE_MIN_EXPERIMENT 0xF0
#define PP2_TYPE_MAX_EXPERIMENT 0xF7
The following range of 8 values is reserved for future use, potentially to
extend the protocol with multibyte type values.
#define PP2_TYPE_MIN_FUTURE 0xF8
#define PP2_TYPE_MAX_FUTURE 0xFF
bneradt
approved these changes
May 14, 2025
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jul 10, 2025
* Add TSVConnPPInfoGet * Set socket type in PPv1 parser as well * Fix nullptr dereference * Change tye type of key parameter to uint16_t (cherry picked from commit c4c31de)
Contributor
|
Cherry-picked to 10.1.x branch |
cmcfarlen
pushed a commit
that referenced
this pull request
Jul 10, 2025
* Add TSVConnPPInfoGet * Set socket type in PPv1 parser as well * Fix nullptr dereference * Change tye type of key parameter to uint16_t (cherry picked from commit c4c31de)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lists.apache.org/thread/nzr39cdvf7277crkf0gf82b7201qxzb8
The API is only tested with PROXY protocol version 1 that doesn't support TLV. I could use Proxy Verifier to use PROXY protocol version 2, but it doesn't seem like to support sending TLV. The PROXY protocol parser itself is tested by unit tests.