-
Notifications
You must be signed in to change notification settings - Fork 848
Explain ATS's default SSL cert selection criteria #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
That's not how it works. In all cases, we should be taking the longest match. If multiple certificates have the same matching specifier we should be issuing a warning and not loading the certificate. |
|
Well, this is how it works regardless of how it should work... But you should be able to specify multiple certs for a given IP (for
|
|
Each certificate is indexed by the subject CN, all the alternate names and the IP address given in ssl_multicert. When we try to match the client connection, we match the SNI name first, then fall back to the IP address. |
|
But what happens if there are 2 found for the same IP address? Which one is
|
|
There's no such thing as a fallback; it's probably confusing to think of it in those terms. We index the certificate in order. In the case of name or address collisions, first certificate into the index is the winner. At lookup time, we search by SNI name, then by address. We always take the longs match, so an explicit name mapping beats a wildcard, and an address:port mapping beats an address mapping. |
|
Correct, and I'm just trying to say that if you have non sni clients its
|
66c515a to
83c2a78
Compare
00d624a to
ac446ce
Compare
|
After talking with @jpeach it sounds like this isn't the case anymore. I'll verify what it does on master then update this PR. @jpeach has a patch which should fix this: http://fpaste.org/176424/22406097/ |
Primarily around certificate loading since there were some questions brought up in apache#121
Primarily around certificate loading since there were some questions brought up in apache#121
Primarily around certificate loading since there were some questions brought up in #121
|
@jpeach Now that it's been fixed upstream, this covers what I was going for |
Update doc-ja branch with upstream/master
Buffer overflow with the incoming port in the host header
Thread ready check
* [PreWarming] Check config strictly if tunnel_prewarm is UNSET * [PreWarming] Fix crash of exceeding proxy.config.tunnel.prewarm.max_stats_size Co-authored-by: Masaori Koshiba <masaori@apache.org>
No description provided.