Skip to content

Couple of coverity fixes. #12145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brbzull0 merged 2 commits into from
Apr 1, 2025
Merged

Couple of coverity fixes. #12145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa2f38b
Fix for CID-1593545: Uninitialized scalar field
brbzull0 Mar 31, 2025
f27942e
Fix for 1593544 : Unchecked return value from library
brbzull0 Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/compress/configuration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class HostConfiguration : private atscppapi::noncopyable
int compression_algorithms_;
unsigned int minimum_content_length_;

RangeRequestCtrl range_request_ctl_;
RangeRequestCtrl range_request_ctl_{RangeRequestCtrl::IGNORE_RANGE};
StringContainer compressible_content_types_;
StringContainer allows_;
// maintain backwards compatibility/usability out of the box
Expand Down
4 changes: 3 additions & 1 deletion src/iocore/net/Server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ Server::listen(bool non_blocking, const NetProcessor::AcceptOptions &opt)
}

if (ats_is_unix(&accept_addr)) {
chmod(accept_addr.sun.sun_path, 0777);
if (chmod(accept_addr.sun.sun_path, 0777) < 0) {
goto Lerror;
}
Copy link
Contributor

@cmcfarlen cmcfarlen Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}

if ((res = safe_listen(sock.get_fd(), get_listen_backlog())) < 0) {
Expand Down