Skip to content

Conversation

@maskit
Copy link
Member

@maskit maskit commented Aug 6, 2025

Autest header_rewrite_url failed on my dev env. Apparently the specialized template function is not used, and the generic one does not consider EXT condition modifier.

@maskit maskit self-assigned this Aug 6, 2025
@maskit maskit added the header_rewrite header_rewrite plugin label Aug 6, 2025
@maskit maskit changed the title header_rewrit: Move template functions into a header file header_rewrite: Move template functions into a header file Aug 6, 2025
@maskit maskit requested a review from zwoop August 6, 2025 23:02
@maskit maskit marked this pull request as ready for review August 6, 2025 23:02
@zwoop
Copy link
Contributor

zwoop commented Aug 6, 2025

I have a rewrite for all autest of header rewrite. I'd prefer not messing with those until I've landed my mega patch.

Copy link
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of having this in the cc file is to avoid unnecessary code duplications. I'd like to understand what the issue is here before we consider this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

header_rewrite header_rewrite plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants