Update header_rewrite to use Regex #12573
Conversation
|
[approve ci autest 1] |
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks good.
We have to remember to remove PCRE::PCRE from our CMakeLists.txt files. I almost missed that in my url_sig PR.
|
[approve ci autest] |
I figured we would take pass after these are done to remove the PCRE dep and cleanup cmake. I can go ahead and remove it though. |
cmcfarlen
force-pushed
the
regex-header-rewrite
branch
from
5a96ebe to
61fc7ce
Compare
| if (!re.setRegexMatch(s, has_modifier(mods, CondModifiers::MOD_NOCASE))) { | ||
| TSError("[%s] Invalid regex: failed to precompile: %s", PLUGIN_NAME, s.c_str()); | ||
| Dbg(pi_dbg_ctl, "Invalid regex: failed to precompile: %s", s.c_str()); | ||
| throw std::runtime_error("Malformed regex"); | ||
| } |
There was a problem hiding this comment.
I assume we're removing the error since this is matching not pre-compiling. Is the Dbg log message wrong too then?
There was a problem hiding this comment.
I moved the error into the helper class so it could also print the regex error. Currently you only get the regex that failed, now you'll get why and what character too.
There was a problem hiding this comment.
Gotcha. Should we move the Dbg log there too though with the extra information.
|
[approve ci autest 3] |
* Update header_rewrite to use Regex * PR review * cast to int * also move dbg for failed regex compile. (cherry picked from commit a15669b)
3 participants
No description provided.