Skip to content

Fix Rocky Linux 8 ASAN plugin tests by suppressing dynamic linker leaks #12675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryancall merged 1 commit into from
Nov 20, 2025
Merged

Fix Rocky Linux 8 ASAN plugin tests by suppressing dynamic linker leaks #12675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/proxy/http/remap/unit-tests/remap_test_dlopen_leak_suppression.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,7 @@
# something nasty or ASAN is detecting a false-positive.
# PluginDso::load
leak:PluginDso::load
leak:call_init
leak:call_init
# On Rocky Linux 8, ASAN reports leaks from the dynamic linker during dlopen
# These are false positives as we properly call dlclose for each dlopen
leak:ld-linux-x86-64.so
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suppression pattern leak:ld-linux-x86-64.so is architecture-specific (x86-64) and may not work on other architectures like ARM64 or i386. Consider using a more portable pattern like leak:ld-linux or documenting that this suppression is x86-64 specific. If Rocky Linux 8 is only supported on x86-64 in CI, this may be acceptable.

Suggested change
leak:ld-linux-x86-64.so
leak:ld-linux

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@bryancall bryancall Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to narrow the scope and only fix CI that is x86.