Clean up certifier SslData destructor #12678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the commented-out debug statement from the SslData destructor. This statement was commented out in PR apache#9792 as a stop-gap measure because it was causing crashes during shutdown when accessing the potentially-destroyed dbg_ctl static object. Let's close the associated issue by just removing the commented out debug statement since it is generally considered unsafe to log in a destructor precisely because of its use of static structures which can surface order-dependent issues like the one reported in apache#9794. That is, not logging in the destructor is the correct solution, so let's just make @maskit's patch official. Fixes: apache#9794
maskit
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the commented-out debug statement from the SslData destructor. This statement was commented out in PR #9792 as a stop-gap measure because it was causing crashes during shutdown when accessing the potentially-destroyed dbg_ctl static object. Let's close the associated issue by just removing the commented out debug statement since it is generally considered unsafe to log in a destructor precisely because of its use of static structures which can surface order-dependent issues like the one reported in #9794. That is, not logging in the destructor is the correct solution, so let's just make @maskit's patch official.
Fixes: #9794