Skip to content

Fix issue where origins could be unintentionally marked as down #12729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masaori335 merged 5 commits into from
Dec 24, 2025
Merged

Fix issue where origins could be unintentionally marked as down #12729

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b696a36
Fix issue where origins could be unintentionally marked as down
yknoya Dec 3, 2025
bd1c192
Set connect_result only when an actual connection error is detected
yknoya Dec 15, 2025
76cd57e
Prevent unnecessary overwriting of error codes
yknoya Dec 15, 2025
ea59532
Revert "Prevent unnecessary overwriting of error codes"
yknoya Dec 19, 2025
5c87945
Revert "Set connect_result only when an actual connection error is de…
yknoya Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/proxy/http/HttpSM.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1823,6 +1823,9 @@ HttpSM::state_http_server_open(int event, void *data)
_netvc->do_io_write(this, 1, _netvc_reader);
_netvc->set_inactivity_timeout(this->get_server_connect_timeout());

// Pre-emptively set a server connect failure that will be cleared once a WRITE_READY is received from origin or
// bytes are received back
t_state.set_connect_fail(EIO);
} else { // in the case of an intercept plugin don't to the connect timeout change
SMDbg(dbg_ctl_http_connect, "not setting handler for connection handshake");
this->create_server_txn(this->create_server_session(*_netvc, _netvc_read_buffer, _netvc_reader));
Expand All @@ -1841,6 +1844,7 @@ HttpSM::state_http_server_open(int event, void *data)
case CONNECT_EVENT_TXN:
SMDbg(dbg_ctl_http, "Connection handshake complete via CONNECT_EVENT_TXN");
if (this->create_server_txn(static_cast<PoolableSession *>(data))) {
t_state.current.server->clear_connect_fail();
handle_http_server_open();
} else { // Failed to create transaction. Maybe too many active transactions already
// Try again (probably need a bounding counter here)
Expand Down Expand Up @@ -8045,9 +8049,6 @@ HttpSM::set_next_state()
}

case HttpTransact::StateMachineAction_t::ORIGIN_SERVER_OPEN: {
// Pre-emptively set a server connect failure that will be cleared once a WRITE_READY is received from origin or
// bytes are received back
t_state.set_connect_fail(EIO);
HTTP_SM_SET_DEFAULT_HANDLER(&HttpSM::state_http_server_open);

// We need to close the previous attempt
Expand Down