Fix convert2yaml.py to handle files without trailing newline #12784
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script was using value[:-1] to strip the trailing newline, which
incorrectly truncates the last character if the file doesn't end with
a newline. Changed to value.rstrip('\n') which properly handles both
cases.
Added test case for config files without trailing newlines.
bryancall
force-pushed
the
fix-convert2yaml-newline
branch
from
6d62fb1 to
f7d63d9
Compare
Contributor
|
Cherry-picked to 10.1.x branch |
cmcfarlen
pushed a commit
that referenced
this pull request
Jan 12, 2026
The script was using value[:-1] to strip the trailing newline, which
incorrectly truncates the last character if the file doesn't end with
a newline. Changed to value.rstrip('\n') which properly handles both
cases.
Added test case for config files without trailing newlines.
(cherry picked from commit dea3657)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script was using
value[:-1]to strip the trailing newline, which incorrectly truncates the last character if the file doesn't end with a newline. Changed tovalue.rstrip('\n')which properly handles both cases.Added test case for config files without trailing newlines.