Skip to content

Restore DbgCtl::_rm_reference() for ABI compatibility #12797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bneradt merged 1 commit into from
Jan 13, 2026
Merged

Restore DbgCtl::_rm_reference() for ABI compatibility #12797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions include/tsutil/DbgCtl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,11 @@ class DbgCtl

static const _TagData *_new_reference(char const *tag);

// Deprecated: backward compatibility stub, no-op since we now use leaky singleton.
// TODO: This can be removed in 11.x because we don't have to worry about
// compatibility there.
static void _rm_reference();

class _RegistryAccessor;

static std::atomic<int> _config_mode;
Expand Down
8 changes: 8 additions & 0 deletions src/tsutil/DbgCtl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,14 @@ DbgCtl::_new_reference(char const *tag)
return new_tag_data;
}

// Deprecated: backward compatibility stub for ABI compatibility with plugins
// compiled against pre-leaky-singleton versions. Does nothing since the
// registry is now never destroyed.
void
DbgCtl::_rm_reference()
{
}

void
DbgCtl::update(const std::function<bool(const char *)> &f)
{
Expand Down