Skip to content

Conversation

@zwoop
Copy link
Contributor

@zwoop zwoop commented Jan 18, 2017

Where the complexity of ::size is not O(1)....

Can someone please carefully review that I did the ++'s and --'s in all the right places?

This fixes #1336.

@zwoop zwoop added the Plugins label Jan 18, 2017
@zwoop zwoop added this to the 7.1.0 milestone Jan 18, 2017
@zwoop zwoop self-assigned this Jan 18, 2017
@zwoop zwoop requested review from bryancall and vmamidi January 18, 2017 21:16
TSMutex _lock;
LRUMap _map;
LRUList _list, _freelist;
size_t _list_size, _freelist_size;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In eleventy, you can do

size_t _list_size = 0;
size_t _freelist_size = 0;

Just FYI, it's not important.

@atsci
Copy link

atsci commented Jan 18, 2017

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1241/ for details.

@atsci
Copy link

atsci commented Jan 18, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1348/ for details.

@zwoop zwoop merged commit 87ca6b4 into apache:master Jan 21, 2017
@zwoop zwoop deleted the #1336 branch October 11, 2017 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cache promote plugin takes too much calculating size of LRUList

3 participants