Skip to content

Allow configurable body factory response max size #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryancall merged 1 commit into from
Jan 31, 2017
Merged

Allow configurable body factory response max size #1391

bryancall merged 1 commit into from
Jan 31, 2017

Conversation

@ibrezac
Copy link
Contributor

@ibrezac ibrezac commented Jan 29, 2017

New config: proxy.config.body_factory.response_max_size

@ibrezac ibrezac force-pushed the body_factory_response_max_size branch from 9d12e5e to fff4b2d Compare January 29, 2017 22:40
@bryancall bryancall self-requested a review January 30, 2017 18:05
@bryancall bryancall added the HTTP label Jan 30, 2017
@bryancall bryancall added this to the 7.2.0 milestone Jan 30, 2017
@bryancall
Copy link
Contributor

bryancall commented Jan 30, 2017

[approve ci]

@atsci
Copy link

atsci commented Jan 30, 2017

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1317/ for details.

@atsci
Copy link

atsci commented Jan 30, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1424/ for details.

@bryancall
Copy link
Contributor

bryancall commented Jan 30, 2017

[approve ci]

@atsci
Copy link

atsci commented Jan 30, 2017

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1318/ for details.

@atsci
Copy link

atsci commented Jan 30, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1425/ for details.

@bryancall
Copy link
Contributor

bryancall commented Jan 30, 2017

Please run clang-format on the code. It is not passing CI.

bryancall
bryancall requested changes Jan 30, 2017
View reviewed changes
Copy link
Contributor

@bryancall bryancall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make clang-format. You will need to have our specific version of clang-format and the documentation can be found here:
https://cwiki.apache.org/confluence/display/TS/Coding+Style#CodingStyle-Indentation

@ibrezac
Allow configurable body factory response max size
4df8b8c 
New config: proxy.config.body_factory.response_max_size
@ibrezac ibrezac force-pushed the body_factory_response_max_size branch from fff4b2d to 4df8b8c Compare January 30, 2017 23:56
@bryancall
Copy link
Contributor

bryancall commented Jan 31, 2017

[approve ci]

@atsci
Copy link

atsci commented Jan 31, 2017

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1326/ for details.

@atsci
Copy link

atsci commented Jan 31, 2017

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1433/ for details.

@bryancall
Copy link
Contributor

bryancall commented Jan 31, 2017

Still needs a clang-format. I will merge it and clang-format it once it is committed.

@bryancall bryancall merged commit d0e5392 into apache:master Jan 31, 2017
@zwoop zwoop modified the milestones: 7.2.0, 8.0.0 Apr 25, 2017
@shinya1020 shinya1020 mentioned this pull request Jan 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryancall bryancall bryancall requested changes

Assignees

@ibrezac ibrezac

Labels

HTTP

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ibrezac @bryancall @atsci @zwoop