issue #1401: Potential fix to the write_to_io_net crash.

[shinrich]

Not a super satisfying solution. Without this change, ats 7.1 would crash immediately in our production environment. With this patch, we run for a few minutes before hitting the next issue.

[atsci]

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1543/ for details.

[atsci]

Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1436/ for details.

[atsci]

clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/107/ for details.

[bryancall]

This is the same type of hack I described in our Monday meeting. I don't think it is worth committing it. Tracking down why this is broken and having a permanent fix would be appropriate.

[shinrich]

Yes, as I said not an entirely satisfying solution. I do think the issue is triggered by the changes from TS-4796 where @jacksontj added logic to bubble up these errors. I'm guessing in some error cases the VC is already partially freed up by this point.

I just checked and the fixes for TS-4796 entered between 7.0 (not there) and 7.1 (is there).

[zwoop]

Fwiw, the fix here (like it or not) prevents the segfaults on docs / Ci.

[shinrich]

Closing in deference to the more complete solution in PR #1522