Skip to content

Fix a crash in PluginVC, reschedule other_side with core_lock_retry_event instead of sm_lock #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oknet wants to merge 1 commit into from
Closed

Fix a crash in PluginVC, reschedule other_side with core_lock_retry_event instead of sm_lock #1687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions proxy/PluginVC.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,10 @@ PluginVC::process_write_side(bool other_side_call)
if (!other_side_call) {
other_side->process_read_side(true);
} else {
other_side->read_state.vio.reenable();
// DO NOT call reenable() here,
// reschedule other_side with core_lock instead of sm_lock.
other_side->need_read_process = true;
other_side->setup_event_cb(0, &other_side->core_lock_retry_event);
}
}
}
Expand Down Expand Up @@ -676,7 +679,10 @@ PluginVC::process_read_side(bool other_side_call)
if (!other_side_call) {
other_side->process_write_side(true);
} else {
other_side->write_state.vio.reenable();
// DO NOT call reenable() here,
// reschedule other_side with core_lock instead of sm_lock.
other_side->need_write_process = true;
other_side->setup_event_cb(0, &other_side->core_lock_retry_event);
}
}
}
Expand Down