Send HPACK dynamic table size update at the beginning of header block #1711
Conversation
|
RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/273/ |
|
clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/259/ |
|
AU check failed! https://ci.trafficserver.apache.org/job/autest-github/255/ |
|
Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/384/ |
|
FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1954/ |
|
Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1846/ |
proxy/http2/HTTP2.cc
Outdated
| int32_t maximum_table_size) | ||
| { | ||
| // Limit the maximum table size to 64kB, which is the size advertised by major clients | ||
| maximum_table_size = min(maximum_table_size, 64 * 1024); |
There was a problem hiding this comment.
It's better to make 64 * 1024 a constant variable.
|
clang-analyzer build failed! https://ci.trafficserver.apache.org/job/clang-analyzer-github/517/ |
|
clang format failed! https://ci.trafficserver.apache.org/job/clang-format-github/269/ |
|
RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/283/ |
|
FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1964/ |
|
AU check failed! https://ci.trafficserver.apache.org/job/autest-github/265/ |
|
Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/394/ |
|
Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1856/ |
|
clang-analyzer build failed! https://ci.trafficserver.apache.org/job/clang-analyzer-github/527/ |
|
I'm OK basically but atsci looks like still angry:( At least, clang-format should be passed. |
|
clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/281/ |
|
RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/295/ |
|
AU check failed! https://ci.trafficserver.apache.org/job/autest-github/277/ |
|
FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1976/ |
|
Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/407/ |
|
Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1868/ |
|
clang-analyzer build failed! https://ci.trafficserver.apache.org/job/clang-analyzer-github/540/ |
|
I've cherry-picked this to 7.1.x branch as well. |
4 participants
This closes #1591.
There are two commits. The first one is a bug fix for the table size update issue. The second commit adds an implementation limit to avoid abusing. The maximum table size is advertised by clients, but we can use any value lower than the value. The value 64k is came from major client implementations.
https://bugzilla.mozilla.org/show_bug.cgi?id=1296280
https://bugs.chromium.org/p/chromium/issues/detail?id=642784
I will squash the commits before merging.