coverity 1021925: Missing break in switch #1782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: CID 1021925 (#1 of 1): Missing break in switch (MISSING_BREAK) unterminated_case: The case for value TS_EVENT_VCONN_WRITE_COMPLETE is not terminated by a 'break' statement. Solution: It was intended not to have a break (not a bug), so refactored the code to make coverity happy.
|
clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/382/ |
|
RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/394/ |
|
AU check successful! https://ci.trafficserver.apache.org/job/autest-github/378/ |
bryancall
approved these changes
May 8, 2017
|
FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/2077/ |
|
Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1970/ |
|
Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/507/ |
|
clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/640/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
CID 1021925 (#1 of 1): Missing break in switch (MISSING_BREAK)
unterminated_case: The case for value TS_EVENT_VCONN_WRITE_COMPLETE is not terminated by a 'break' statement.
Solution:
It was intended not to have a break (not a bug), so refactored the code to make coverity happy.