Skip to content

Conversation

@zizhong
Copy link
Member

@zizhong zizhong commented May 10, 2017

(cherry picked from commit 0d39b4a)

Conflicts:
proxy/http2/HTTP2.cc

@zizhong
Copy link
Member Author

zizhong commented May 10, 2017

This is the backport of #1747. @zwoop

@maskit maskit added Backport Marked for backport for an LTS patch release HTTP/2 labels May 10, 2017
@maskit maskit added this to the 7.1.0 milestone May 10, 2017
@bryancall bryancall assigned zizhong and unassigned zwoop May 11, 2017
@PSUdaemon
Copy link
Contributor

[approve ci]

@PSUdaemon
Copy link
Contributor

@zizhong I think you need to rebase to address that clang-analyzer failure.

@zwoop should this still be an issue?

@zizhong zizhong force-pushed the 7.1.x_http2spec branch from 57e2491 to f9c687f Compare May 15, 2017 17:55
(cherry picked from commit 0d39b4a)

Conflicts:
	proxy/http2/HTTP2.cc
@zizhong zizhong force-pushed the 7.1.x_http2spec branch from f9c687f to b986920 Compare May 15, 2017 17:59
@zizhong
Copy link
Member Author

zizhong commented May 15, 2017

@PSUdaemon rebased. Can you try it again?

@zwoop zwoop self-requested a review May 23, 2017 23:41
@zwoop
Copy link
Contributor

zwoop commented May 24, 2017

Trying again, the CA and autest failures are probably as expected (sigh), but the RAT failure was due to an issue on the CI. [approve ci]

Copy link
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@maskit maskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any concerns to backport this.

@zwoop zwoop merged commit 357a18e into apache:7.1.x May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport Marked for backport for an LTS patch release HTTP/2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants