Server information should be cleared when following redirect #1978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@AMC points out that this probably want to use ink_zero(). |
vmamidi
force-pushed
the
clear_server_info_in_redirect
branch
from
872f47a to
db15f82
Compare
Contributor
|
I think @jrushford and @PSUdaemon wants this for 6.2.x as well, since they took the original change already? |
Contributor
|
@vmamidi because of coverity cleanup, this also doesn't apply cleanly to 7.1.x. It's a simple fix, but to follow the rule book, can you please make a separate PR for the 7.1.x branch, with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #1756, clearing the server information was not required while following a redirect as DNS was always done under all circumstances. Now, ATS does DNS only it is required so, server information should be cleared while following the redirect.