Skip to content

Add override specifiers to Http2Stream class #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maskit merged 1 commit into from
Jun 12, 2017
Merged

Add override specifiers to Http2Stream class #2113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions proxy/http2/Http2Stream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class Http2Stream : public ProxyClientTransaction
~Http2Stream() { this->destroy(); }
int main_event_handler(int event, void *edata);

void destroy();
void destroy() override;

bool
is_body_done() const
Expand Down Expand Up @@ -137,15 +137,15 @@ class Http2Stream : public ProxyClientTransaction

Http2ErrorCode decode_header_blocks(HpackHandle &hpack_handle);
void send_request(Http2ConnectionState &cstate);
VIO *do_io_read(Continuation *c, int64_t nbytes, MIOBuffer *buf);
VIO *do_io_write(Continuation *c, int64_t nbytes, IOBufferReader *abuffer, bool owner = false);
void do_io_close(int lerrno = -1);
VIO *do_io_read(Continuation *c, int64_t nbytes, MIOBuffer *buf) override;
VIO *do_io_write(Continuation *c, int64_t nbytes, IOBufferReader *abuffer, bool owner = false) override;
void do_io_close(int lerrno = -1) override;
void initiating_close();
void do_io_shutdown(ShutdownHowTo_t) {}
void do_io_shutdown(ShutdownHowTo_t) override {}
void update_read_request(int64_t read_len, bool send_update);
bool update_write_request(IOBufferReader *buf_reader, int64_t write_len, bool send_update);
void reenable(VIO *vio);
virtual void transaction_done();
void reenable(VIO *vio) override;
virtual void transaction_done() override;
void send_response_body();
void push_promise(URL &url);

Expand Down Expand Up @@ -187,17 +187,17 @@ class Http2Stream : public ProxyClientTransaction
return chunked;
}

void release(IOBufferReader *r);
void release(IOBufferReader *r) override;

virtual bool
allow_half_open() const
allow_half_open() const override
{
return false;
}

virtual void set_active_timeout(ink_hrtime timeout_in);
virtual void set_inactivity_timeout(ink_hrtime timeout_in);
virtual void cancel_inactivity_timeout();
virtual void set_active_timeout(ink_hrtime timeout_in) override;
virtual void set_inactivity_timeout(ink_hrtime timeout_in) override;
virtual void cancel_inactivity_timeout() override;
void clear_inactive_timer();
void clear_active_timer();
void clear_timers();
Expand All @@ -217,7 +217,7 @@ class Http2Stream : public ProxyClientTransaction
}

bool
is_first_transaction() const
is_first_transaction() const override
{
return is_first_transaction_flag;
}
Expand Down