#2220 use parsed_hosts_file_ptr only if it has valid value #2221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[approve ci]. |
Contributor
|
Please run "make clang-format" and push the updated changes (squash the commits as well, so you will have to force push). |
liodot
force-pushed
the
null_hosts_file_ptr
branch
from
6d25693 to
2be4a64
Compare
Contributor
Author
|
I've done a forced push after running "make clang-format" |
Contributor
|
[approve ci]. |
Contributor
|
Cherry picked to 7.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2220
When ATS is configured to use a hosts file (via proxy.config.hostdb.host_file.path) and fails to open it, there's a crash:
#0 0x00000000006e4ccc in std::_Rb_tree<ts::ConstBuffer, std::pair<ts::ConstBuffer const, IpAddr>, std::_Select1st<std::pair<ts::ConstBuffer const, IpAddr> >, CmpConstBuffferCaseInsensitive, std::allocator<std::pair<ts::ConstBuffer const, IpAddr> > >::_M_begin (this=0x10) at /usr/include/c++/4.9/bits/stl_tree.h:518
#1 0x00000000006e4f05 in std::_Rb_tree<ts::ConstBuffer, std::pair<ts::ConstBuffer const, IpAddr>, std::_Select1st<std::pair<ts::ConstBuffer const, IpAddr> >, CmpConstBuffferCaseInsensitive, std::allocator<std::pair<ts::ConstBuffer const, IpAddr> > >::find (this=0x10, __k=...) at /usr/include/c++/4.9/bits/stl_tree.h:1913
#2 0x00000000006e48a9 in std::map<ts::ConstBuffer, IpAddr, CmpConstBuffferCaseInsensitive, std::allocator<std::pair<ts::ConstBuffer const, IpAddr> > >::find (this=0x10, __x=...)
at /usr/include/c++/4.9/bits/stl_map.h:860
#3 0x00000000006dd237 in HostDBContinuation::do_dns (this=0x7f8e1a9d65e0) at HostDB.cc:1993
#4 0x00000000006dcd91 in HostDBContinuation::probeEvent (this=0x7f8e1a9d65e0, e=0x7f8df0252b00) at HostDB.cc:1932
#5 0x000000000050ce28 in Continuation::handleEvent (this=0x7f8e1a9d65e0, event=2, data=0x7f8df0252b00) at ../iocore/eventsystem/I_Continuation.h:153
#6 0x00000000007b7d11 in EThread::process_event (this=0x7f8e16c0a010, e=0x7f8df0252b00, calling_code=2) at UnixEThread.cc:148
#7 0x00000000007b8120 in EThread::execute (this=0x7f8e16c0a010) at UnixEThread.cc:230
#8 0x00000000007b72bb in spawn_thread_internal (a=0x1612870) at Thread.cc:86
#9 0x00007f8e193eb6ba in start_thread (arg=0x7f8e161ff700) at pthread_create.c:333
#10 0x00007f8e1867582d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
Found on ATS 6.2.1 but looks applicable to current master.