Skip to content

Conversation

@ywkaras
Copy link
Contributor

@ywkaras ywkaras commented Oct 10, 2017

No description provided.

@bryancall bryancall added this to the 8.0.0 milestone Oct 10, 2017
@bryancall
Copy link
Contributor

Can you explain why this is needed?

@mlibbey
Copy link
Contributor

mlibbey commented Oct 10, 2017

How does this work for includes?

Hard to imagine enough use of this to be in the core -- Seems like this might be better suited for a plugin (though, admittedly I've no clue if that'd be easy or terribly difficult).

@zwoop
Copy link
Contributor

zwoop commented Oct 10, 2017

A line number into some unversioned / unidentified configuration file seems fairly useless. Two thoughts:

  1. If you are looking for better debugging, I'd suggest more Diagnostic tags.
  2. If you are looking to identify "services", I'd say use something like header_rewrite to set an @-header which identifies the service.

#2 is what we use to identify services (which maps more or less directly to the right remap line(s)). These @-headers can still be logged as well (that's already supported, of course, since it's just a header).

@ywkaras
Copy link
Contributor Author

ywkaras commented Oct 10, 2017

@bryancall because Dave Carlin asked for it (Oath internal TS issue/defect).

@ywkaras
Copy link
Contributor Author

ywkaras commented Dec 4, 2017

Closing to remove clutter from open PR list.

@ywkaras ywkaras closed this Dec 4, 2017
@zwoop zwoop removed this from the 8.0.0 milestone May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants