Skip to content

Conversation

@scw00
Copy link
Member

@scw00 scw00 commented Nov 12, 2017

No description provided.

@scw00 scw00 self-assigned this Nov 12, 2017
@scw00 scw00 requested a review from zwoop November 12, 2017 08:27
@scw00 scw00 added the Tests label Nov 12, 2017
@scw00 scw00 requested a review from dragon512 November 12, 2017 08:27
@scw00 scw00 added this to the 8.0.0 milestone Nov 12, 2017
@scw00 scw00 requested a review from bryancall November 12, 2017 08:27
@scw00
Copy link
Member Author

scw00 commented Nov 12, 2017

This is the test for #2766 .

)

tr = Test.AddTestRun()
tr.Processes.Default.Command = 'touch largefile.txt && truncate largefile.txt -s 50M && curl -i http://127.0.0.1:{0}/redirect1 -F "filename=@./largefile.txt"'.format(ts.Variables.port)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragon512 Do we need to remove this file ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scw00 If I am reading this test right this file is in the sandbox. The test system will clean up any file in the sandbox for you. So you should be good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds fine, although, I'd be cautious here, if it's not too cumbersome to clean out such a large file, I think you should do it. Imagine a sandbox getting left somewhere for whatever reason it might be, it could quickly fill up the disks.

@scw00 scw00 force-pushed the post_redirect_autest branch from b256a25 to 8de5ece Compare November 18, 2017 02:47
@bryancall
Copy link
Contributor

[approve ci autest]

@scw00 scw00 force-pushed the post_redirect_autest branch from 8de5ece to aa5ed39 Compare November 18, 2017 04:13
@scw00
Copy link
Member Author

scw00 commented Nov 18, 2017

It worked now !

@bryancall bryancall merged commit 4b5218f into apache:master Nov 18, 2017
@scw00 scw00 deleted the post_redirect_autest branch March 15, 2018 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants