Skip to content

Do not propagate origin Connection:close to client http/2 session. #3061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shinrich wants to merge 1 commit into from
Closed

Do not propagate origin Connection:close to client http/2 session. #3061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions proxy/http2/Http2Stream.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,19 +586,6 @@ Http2Stream::update_write_request(IOBufferReader *buf_reader, int64_t write_len,
case PARSE_RESULT_DONE: {
this->response_header_done = true;

// Schedule session shutdown if response header has "Connection: close"
MIMEField *field = this->response_header.field_find(MIME_FIELD_CONNECTION, MIME_LEN_CONNECTION);
if (field) {
int len;
const char *value = field->value_get(&len);
if (memcmp(HTTP_VALUE_CLOSE, value, HTTP_LEN_CLOSE) == 0) {
SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
if (parent->connection_state.get_shutdown_state() == HTTP2_SHUTDOWN_NONE) {
parent->connection_state.set_shutdown_state(HTTP2_SHUTDOWN_NOT_INITIATED);
}
}
}

// Send the response header back
parent->connection_state.send_headers_frame(this);

Expand Down