Fixing 404 on redirects #3282
Merged
Fixing 404 on redirects #3282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bug introduced with PR apache#2335. The `if` is to avoid unnecessary works when buffering the post body, but since redirects also need to execute the logic flow and the request info may be changed during the process of redirects. We need to extract the request info every time redirects happen.
Member
Author
|
@zwoop @SolidWallOfCode @zwoop please review! |
zwoop
approved these changes
Mar 14, 2018
Contributor
zwoop
left a comment
zwoop
left a comment
There was a problem hiding this comment.
Yeh, this works. This would probably be worthwhile making an autest for (although, obviously not using bintray as the origin).
Member
Author
|
@zwoop yes, I will add a test for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug introduced with PR #2335. The
ifis to avoid unnecessaryworks when buffering the post body, but since redirects also need to
execute the logic flow and the request info may be changed during the
process of redirects. We need to extract the request info every time redirects
happen.