-
Notifications
You must be signed in to change notification settings - Fork 847
Adding proxy.config.http.allow_half_open #3325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d638532 to
007bf1b
Compare
007bf1b to
92e660a
Compare
scw00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! thanks
|
Hi @zwoop @bryancall |
|
|
||
| Turn on or off support for connection half open for client side. Default is on, so | ||
| after client sends FIN, the connection is still there. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please inform the end user that it is dangerous to turn it off. It can only be turned off in special scenario.
|
We plan to talk about half open at the summit this Spring. Please hold off merging this till after. |
|
The implementation looks fine to me. Should probably rename it to allow_half_closed if we decide to go with this. Probably my fault. I added allow_half_open method to the ProxyClient* classes. In the general community it seems that half open refers to embryonic connections (got the SYN but not the SYN-ACK). And half closed refers to this situation. Most of the code refers to half_close_flag's, so I just had a brain bubble when naming my method. |
|
In the discussion at the Euro Tour, the consensus was to add this flag and during the 8.0 time frame add metrics to figure out how often this really happens for various scenarios. |
This is a workaround for issue #3288.
This PR is to give a workaround with little risk until we figure out what the proper way to fix #3288.
@bryancall @zwoop @oknet @scw00 any ideas would be much appreciated.