Skip to content

Fixed h2spec 5.1-11 test when sending a data frame to the server on a closed stream #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bryancall wants to merge 1 commit into from
Closed

Fixed h2spec 5.1-11 test when sending a data frame to the server on a closed stream #3857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion proxy/http2/Http2ConnectionState.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,11 @@ rcv_data_frame(Http2ConnectionState &cstate, const Http2Frame &frame)

Http2Stream *stream = cstate.find_stream(id);
if (stream == nullptr) {
if (cstate.is_valid_streamid(id)) {
if (cstate.is_valid_streamid(id) &&
cstate.get_client_stream_count() >= cstate.server_settings.get(HTTP2_SETTINGS_MAX_CONCURRENT_STREAMS)) {
// This error occurs fairly often, and is probably innocuous (SM initiates the shutdown)
// Only send a stream error if we are over the number of current streams. Always sending stream errors if the stream id is
// only valid breaks the 5.1-11 test with h2spec
return Http2Error(Http2ErrorClass::HTTP2_ERROR_CLASS_STREAM, Http2ErrorCode::HTTP2_ERROR_STREAM_CLOSED, nullptr);
} else {
return Http2Error(Http2ErrorClass::HTTP2_ERROR_CLASS_CONNECTION, Http2ErrorCode::HTTP2_ERROR_PROTOCOL_ERROR,
Expand Down