PROXY Protocol transformed to Forwarded HTTP header #3956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reveller
force-pushed
the
8.0.x-proxy-protocol
branch
from
76e0e84 to
123c846
Compare
reveller
changed the title
bryancall
approved these changes
Aug 31, 2018
bryancall
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds a port descriptor option for enabling Proxy Protocol as well as a whitelist of trusted IP addresses as sources of incoming requests with Proxy Protocol headers. If the the Proxy Protocol is enabled and the PROXY header is prefaced on an incoming request, the remote address is changed internally to reflect the original client IP. This has the side effect of transforming the originating IP address into the Forwarded: header for: field, if proxy.config.http.insert_forwaded is configured with the for: field. This will also facilitate logging of the proper client IP versus the previous hop address, i.e. load balancer.