Skip to content

Conversation

@SolidWallOfCode
Copy link
Member

Depends on #3955.

This started as an effort to replace a use of TCL hash with IntrusiveHashMap but to make that work well I had to do a major refresh to bring the base code up to C++ eleventy standards. Overall IntrusiveHashMap worked well, although I did end up adding the apply method and doing an overhaul of the documentation (both of those now blended in to #3955).

@zwoop
Copy link
Contributor

zwoop commented Jul 19, 2018

Is there something that still needs TCL after this? If no, we should nuke TCL from the build dependencies too.

@zwoop
Copy link
Contributor

zwoop commented Jul 19, 2018

I also think this is worthy of a 8.0.0 back port, but maybe it's a little risky? But if it does indeed eliminate TCL, it'd be great to have that gone out of 8.0.0.

@SolidWallOfCode
Copy link
Member Author

It's just a first step. It eliminates it from the HostLookup matcher logic, but the TCL hash table is still in use elsewhere. Primarily this is a trial run to validate the approach. Next step is to replace TSHashTable with this, which should be simpler. That eliminates TSHashTable. Then start replacing other uses of ink_hash_table. I suppose I could look at rewriting ink_hash_table using this and then converting, because no small part of the win is having a much nicer interface.

@SolidWallOfCode
Copy link
Member Author

Going to have this redone using STL containers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants