Enable ECDH explicitly only if OpenSSL version is v1.0.2 or lower #4039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSL_CTX_set_ecdh_auto() has been removed and ECDH is enabled in default since OpenSSL v1.1.0.
Contributor
Author
|
FWIW, BoringSSL defines |
bryancall
approved these changes
Jul 31, 2018
Contributor
|
Cherry-picked to 8.0.x |
Contributor
|
@masaori335 Do we want this for 7.1.5 as well ? If so, please make a separate PR, so we can set a different Milestone on that commit. |
Contributor
Author
|
@zwoop Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL_CTX_set_ecdh_auto() has been removed and ECDH is enabled in default since OpenSSL v1.1.0.
Fix #4038