Fixed url_sig error when storing base64ed params in penultimate segment. #4042
Conversation
| char *p = NULL, *sig_anchor = NULL, *saveptr = NULL; | ||
| int i = 0, numtoks = 0, cp_len = 0, l, decoded_len = 0, sig_anchor_seg = 0; | ||
| int i = 0, numtoks = 0, decoded_len = 0, sig_anchor_seg = 0; | ||
|
|
There was a problem hiding this comment.
could use nullchecks on all the things
There was a problem hiding this comment.
No null checks in the old things, and my goal wasn't wholesale rewrite, but just a return to existing behavior. These are pretty safe, though, cause if we get a null ptr here, we're already in pretty bad shape much earlier.
| } | ||
| } | ||
|
|
||
| /** fixedBufferWrite safely writes no more than *dest_len bytes to *dest_end |
There was a problem hiding this comment.
Did you consider using ts::FixedBufferWriter for this?
There was a problem hiding this comment.
Nope. Is there a straight C version though? I am mostly just trying to get the code back to what it used to do before strncat got turned into memcpy.
There was a problem hiding this comment.
Yeah, no C version. Dang. I keep forgetting people still write code in C. Oh well, nevermind.
4 participants
This should be cherry-picked into 7 and 8, too.