Replace TRY_MUTEX_LOCK_FOR with equivalent TRY_MUTEX_LOCK #4111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolidWallOfCode
approved these changes
Aug 14, 2018
Contributor
|
[approve ci autest] |
Contributor
|
Removing the 7.1.x Project for now, please make a PR against 7.1.x branch if we need / want this for 7.1.x |
Contributor
|
Cherry picked to 8.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The continuation parameter for TRY_MUTEX_LOCK_FOR is unused making it equivalent to TRY_MUTEX_LOCK. The unused continuation parameter is confusing when reading the code making you thing the continuation is involved somehow in the operation.
This PR removes TRY_MUTEX_LOCK_FOR and replaces all uses with TRY_MUTEX_LOCK.
TRY_MUTEX_LOCK_SPIN was unused, so I removed that while I was in there.