revoke promise when provider is gone #4152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
better to backport this if needed. |
zizhong
requested review from
SolidWallOfCode,
bryancall,
oknet,
scw00,
shinrich and
zwoop
Member
Author
|
kindly ping if you got time. @bryancall @zwoop @SolidWallOfCode @shinrich @scw00 @oknet |
shinrich
previously approved these changes
Sep 6, 2018
Member
shinrich
left a comment
shinrich
left a comment
There was a problem hiding this comment.
I am not very familiar with the cppapi, but your logic does seem reasonable to track and free the memory associated with the promise.
lib/cppapi/include/atscppapi/Async.h
Outdated
|
|
||
| #pragma once | ||
|
|
||
| #include <list> |
Member
There was a problem hiding this comment.
Do you still need <list>?
zizhong
force-pushed
the
async_mem_leak
branch
from
fafa3d4 to
a58a6fc
Compare
Member
Author
|
@shinrich @SolidWallOfCode list header is removed. |
zizhong
force-pushed
the
async_mem_leak
branch
from
a58a6fc to
f430679
Compare
Member
Author
|
Conflicts resolved. |
Member
Author
|
@shinrich @SolidWallOfCode mind take another look? Thank you very much! |
SolidWallOfCode
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the memory leak issue #4137 .