IP: Use meta case logic to handle sockaddr length field instead of autotools. #4153
+37
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolidWallOfCode
force-pushed
the
ip-meta-socklen
branch
from
58fa8e9 to
d769519
Compare
shinrich
reviewed
Oct 25, 2018
| memcpy(dst, src, n); | ||
| #if HAVE_STRUCT_SOCKADDR_SA_LEN | ||
| dst->sa_len = n; | ||
| #endif |
Member
There was a problem hiding this comment.
Where does the template approach deal with sa_len?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #4140.
This removes the autotools checking for whether
sockaddrstructs have a length field and does it directly inline using the meta case utility.