Skip to content

Fix another ProxySession and NetVC shutdown race crash #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shinrich merged 1 commit into from
Sep 5, 2018
Merged

Fix another ProxySession and NetVC shutdown race crash #4178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions proxy/ProxyClientSession.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,6 @@ ProxyClientSession::handle_api_return(int event)
}
break;
case TS_HTTP_SSN_CLOSE_HOOK: {
NetVConnection *vc = this->get_netvc();
if (vc) {
vc->do_io_close();
}
free(); // You can now clean things up
break;
}
Expand Down
5 changes: 5 additions & 0 deletions proxy/http/Http1ClientSession.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,11 @@ Http1ClientSession::free()
// Free the transaction resources
this->trans.super_type::destroy();

if (client_vc) {
client_vc->do_io_close();
client_vc = nullptr;
}

super::free();
THREAD_FREE(this, http1ClientSessionAllocator, this_thread());
}
Expand Down